demo,demo_rfcn use cpu version of nms when in cpu_mode #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nms_wrapper.py uses CPU mode when cfg.USE_GPU_NMS isn't set or it's passed force_cpu as True.
When --cpu was provided, demo.py and demo_rfcn.py did not set cfg.USE_GPU_NMS, which defaulted to True. So, NMS always operated in GPU mode. This caused sometimes the console to spew 'unknown error', and the bounding boxes on each object to not be combined; in other setups the program did not run at all.