Grab the files from the RSS Bridge master directly #54
Conversation
Upgrade to v2022-06-14
I am wondering if changing directly to the master/main branch in this manner is ok since we can do it whenever we desire to keep this package updated. No need to use commits. Simply use the main branch and from time to time easily change the shasum and the ynh versioning number and we are done. RSS Bridge does not have releases anymore. And this ynh package is not updated in a year or so.
|
Ah it will not work since the shasum wont be the same if there are new commits....damn.....is there a way around this? What if we do not use shasum for this and skip it? |
|
Will first make sure if they plan new releases or not rely on that anymore. Then we can switch to a commit instead of the master branch directly. Will update it all here. |
Oh that's why I didn't receive any notification.
Certainly not. That introduce a security breach for all users.
One time-consuming but relatively easy to implement option is to make the release archive ourselves from time to time, based on a dedicated commit. |
|
So we can use commits for sure like so "https://github.com/RSS-Bridge/rss-bridge/archive/4e616c7092b0fa2ad181117817ab80ad6cf4dfef.tar.gz" - I opened a discussion over here RSS-Bridge/rss-bridge#3322 (comment) let's see what the RSS Bridge devs are saying. But I suspect the saner way is to pull from commits else their release cycle is so slow that it makes this service unusable in many ways. |
| SOURCE_URL=https://github.com/RSS-Bridge/rss-bridge/archive/refs/heads/master.zip | ||
| SOURCE_SUM=c39b875e1b2c047662b06366f63a6888f6fba3c5146e2034433f06a7e40594d3 |
There was a problem hiding this comment.
| SOURCE_URL=https://github.com/RSS-Bridge/rss-bridge/archive/refs/heads/master.zip | |
| SOURCE_SUM=c39b875e1b2c047662b06366f63a6888f6fba3c5146e2034433f06a7e40594d3 | |
| SOURCE_URL=https://github.com/RSS-Bridge/rss-bridge/archive/307f5865c0bd12c32e7c5bdc0869dd0dcd403e40.zip | |
| SOURCE_SUM=f539b420d153485a9495105bedf4197ae9c54ed5b391d4e70b3c403aa76bc96c |
I would suggest to use a source archive for the specific commit number (I took the latest commit in the master branch at the moment). This way it should be deterministic between multiple installs and should download the same sources until the link will be changed again.
Also, this change would require a change of the package version postfix at least ~ynh3..~ynh4 to notify users that package is changed.
There was a problem hiding this comment.
Also, this change would require a change of the package version postfix at least ~ynh3..~ynh4 to notify users that package is changed.
If we change the commit version, the whole version name has to change.
I believe this PR will bring a newer version anyway.
There was a problem hiding this comment.
If we change the commit version, the whole version name has to change.
Yes, then since Bridge developers are using the dates, it might be a date of the commit was used in update, e.g. 2023.03.21.
There was a problem hiding this comment.
I would suggest as well to point to a specific commit archive, and change the package version each. An example in the ttrss package: https://github.com/YunoHost-Apps/ttrss_ynh/blob/master/manifest.toml#L43
There was a problem hiding this comment.
This issue is that it's a burden to maintain and test.
But if no new releases are going to be made, then we might have no choice.
There was a problem hiding this comment.
This issue is that it's a burden to maintain and test. But if no new releases are going to be made, then we might have no choice.
How is the SearxNG managed? It seems to push updates every other day.
|
Any updates about this? My instance does not work properly and the RSSBridge devs said it might be because they always fix things and our package is really old. Let's try to pull from git master please. If you guys can implement this I can for sure change the commit numbers and ynh versioning every so often so that we have an updated version of RSS Bridge. https://github.com/RSS-Bridge/rss-bridge/commits/master |
|
And I think the package naming should be easy. Take this: Can be the date of the commit. 2023.09.13~ynh1 |
That's the usual procedure, yes.
Do they plan to use releases (again ?) or will they stick to a rolling-release style on a main branch ? |
|
Strangely the error you report with Youtube bridge does not happen in my case. Which version of the package are you using ? |
I do not know but for such a package pulling from master seems like a better idea since many sources may not play well with RSS and these devs are fixing a bunch of things. Same with SearxNG - and it is good that YNH pulls from git directly (from my understanding).
As it was mentioned in that issue it could be because my instance is more popular but recent RSS Bridge changes may bypass that. I will have to check with the latest from master as it was suggested, to find out the cause. My version is 2023.07.13~ynh2 |
The thing is it introduce a constant burden of maintenance to watch for changes, decide which commit to use, upgrade the package and test it. |
|
From what I understand their official instance runs from master. So should be ok. |
|
So is that master branch the "stable" one, where few development happen, or is that just that the official instance serves for testing purposes too ? |
|
Now that they are doing releases more often lets stick to that! Should we close this for now? |
I am wondering if changing directly to the master/main branch in this manner is ok since we can do it whenever we desire to keep this package updated. No need to use commits. Simply use the main branch and from time to time easily change the shasum and the ynh versioning number and we are done. RSS Bridge does not have releases anymore. And this ynh package is not updated in a year or so.