Fix bug when setting Verific runtime string flags. #4734
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Inouye <[email protected]>
|
Hey @povik, if you get a moment can you review this PR? |
povik
approved these changes
Nov 14, 2024
|
Thanks Martin |
|
Sure Mike, I am not the maintainer of the Verific integration but here it's clear enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
The setting of Verific runtime string flags does not work within Yosys as it encapsulates the value in quotes.
Explain how this is achieved.
Temp string s that is preexisting is correctly passed into Verific RuntimeFlags call.
If applicable, please suggest to reviewers how they can test the change.
Attempting to change the value of a Verific string RuntimeFlag will fail before this change.