read_liberty extensions #4682
Open
read_liberty extensions #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widlarizer
reviewed
Nov 11, 2024
frontends/liberty/liberty.cc
Outdated
| @@ -462,6 +462,9 @@ struct LibertyFrontend : public Frontend { | |||
| log(" -ignore_miss_data_latch\n"); | |||
| log(" ignore latches with missing data and/or enable pins\n"); | |||
| log("\n"); | |||
| log(" -ignore_busses\n"); | |||
There was a problem hiding this comment.
nit: wiktionary says "buses is the usual plural of bus in both British and American English, ignoring the typical doubling of consonants"
The raw files are supposed to be dropped from the PR once we fix #4681 |
|
Postpone handling re-definitions to after we have established the cell is not supposed to be ignored on the grounds of one of the user-provided flags.
povik
force-pushed
the
read_liberty-extensions
branch
from
396eb5a
to
56a9202
Compare
Force pushed to remove the unfiltered data, and to check in gzipped versions of the filtered data |
widlarizer
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
This addresses a few things:
read_liberty -wbcan only read some cells (not those with busses), but combining it with a separateread_liberty -libcall as fallback doesn't always work well because of how the command handles re-definitions, see commit 2f2726d with a fix-ignore_bussesoptionareaandcapacitanceattributes for e.g. user inspection or to find the smallest gate implementing a particular functionAlso I checked in some real-world Liberty data to use in tests, and have written tests using those (incl. for the existing
-unit_delayoption)