Refactor getting dirs and filenames from paths to files #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
requested changes
Sep 11, 2024
|
I agree, I would also just move over the basename/filename function, there are already directory/file related functions present in yosys_common |
widlarizer
changed the title
|
looks good to me |
whitequark
reviewed
Sep 13, 2024
|
|
||
| // Includes OS_PATH_SEP at the end | ||
| std::string parent_from_file_path(std::string path) { | ||
| return path.substr(0, path.find_last_of(OS_PATH_SEP)+1); |
There was a problem hiding this comment.
What happens if path.find_last_of(OS_PATH_SEP) returns std::string::npos?
There was a problem hiding this comment.
To me it looks like it'll return "", which does not include OS_PATH_SEP at the end. This either needs a documentation change or an assertion.
widlarizer
force-pushed
the
emil/path-sep-refactor
branch
from
13ba44f
to
1759609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4592 (comment)