4475 fix related keyphrase status

[mykola]

Context

• Fix related keyphrase status neutral/orange instead of happy/green when all the results are good.

Summary

This PR can be summarized in the following changelog entry:

• [yoastseo] Fixes related keyphrase status neutral/orange instead of happy/green when all the results are good.
• [shopify-seo] Fixes related keyphrase status neutral/orange instead of happy/green when all the results are good.

Relevant technical choices:

• New RelatedKeywordScoreAggregator was added that before aggregate filter assessments without score. Similar approach is used in ReadabilityScoreAggregator

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Create a post with content (this article can be used).
• Click Add related keyphrase -> Keyphrase: insights
• Make sure that scores green for every assessment.
• Make sure that status of the Related keyphrase emote is happy/green (one in the header of Related keyphrase)
• Run the test in WordPress and in Shopify

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• For solution separate a separate score aggregator was introduced that should impact only Related Keyword but please do smoke test for Premium SEO analysis.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #4475

[coveralls]

Pull Request Test Coverage Report for Build 73b1ad27f8fb0a715d3e0656df754f6f351beca5

Details

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 54.629%

---

Totals
Change from base Build 01c6afdf2feaddb2d89d45d0f50dfbce38e34b57:	0.003%
Covered Lines:	30109
Relevant Lines:	55471

---

💛 - Coveralls