Add the phrase "dumb down" and improve feedback for the word "lame" in the Inclusive language assessment #21578
+94
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannaw93
added
the
changelog: enhancement
hannaw93
changed the base branch from
trunk
to
feature/inclusive-language-fixes
agnieszkaszuba
requested changes
Nov 5, 2024
Comment on lines
224
to
+237
| identifier: "lamer", | ||
| nonInclusivePhrases: [ "lamer" ], | ||
| inclusiveAlternatives: "<i>more boring, lousier, more unimpressive, sadder, cornier</i>", | ||
| score: SCORES.NON_INCLUSIVE, | ||
| feedbackFormat: redHarmful, | ||
| inclusiveAlternatives: "<i>more boring, lousier, more unimpressive, sadder, cornier</i>, <i>person with a disability, person who has difficulty with walking</i>", | ||
| score: SCORES.POTENTIALLY_NON_INCLUSIVE, | ||
| feedbackFormat: [ "Be careful when using <i>%1$s</i> as it is potentially harmful. " + | ||
| "Unless you are referring to an object, considering using an alternative. For example, %1$s. If referring to someone's disability, use an alternative such as %2$s." ], | ||
| }, | ||
| { | ||
| identifier: "lamest", | ||
| nonInclusivePhrases: [ "lamest" ], | ||
| inclusiveAlternatives: "<i>most boring, lousiest, most unimpressive, saddest, corniest</i>", | ||
| score: SCORES.NON_INCLUSIVE, | ||
| feedbackFormat: redHarmful, | ||
| inclusiveAlternatives: "<i>most boring, lousiest, most unimpressive, saddest, corniest</i>, <i>person with a disability, person who has difficulty with walking</i>", | ||
| score: SCORES.POTENTIALLY_NON_INCLUSIVE, | ||
| feedbackFormat: [ "Be careful when using <i>%1$s</i> as it is potentially harmful. " + | ||
| "Unless you are referring to an object, considering using an alternative. For example, %1$s. If referring to someone's disability, use an alternative such as %2$s." ], |
There was a problem hiding this comment.
'Lamer' and 'lamest' don't need the feedback for 'lame' as an object, since when 'lame' is used as a noun it wouldn't take these forms.
And I think the person with a disability, person who has difficulty with walking alternatives would need to be adapted to the comparative and superlative forms.
| inclusiveAlternatives: "<i>oversimplify</i>", | ||
| score: SCORES.NON_INCLUSIVE, | ||
| feedbackFormat: redHarmful, | ||
| }, | ||
| { | ||
| identifier: "dumb", |
There was a problem hiding this comment.
We also need to add a rule to not show the feedback for 'dumb' when followed by 'down' or 'it down'.
Comment on lines
+323
to
+330
| { | ||
| identifier: "dumbDown", | ||
| nonInclusivePhrases: [ "dumb down", "dumbing down", "dumbed down", "dumb it down", "dumbing it down", | ||
| "dumbed it down" ], | ||
| inclusiveAlternatives: "<i>oversimplify</i>", | ||
| score: SCORES.NON_INCLUSIVE, | ||
| feedbackFormat: redHarmful, | ||
| }, |
There was a problem hiding this comment.
You could consider splitting this up so that each form gets the alternative in a matching form of 'oversimplify'. For example 'dumbing down' -> 'oversimplifying' etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
"Avoid using dumb as it is potentially harmful. Consider using an alternative, such as uninformed, ignorant, foolish, inconsiderate, irrational, reckless. Learn more.".
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #