ура #5
Open
ура #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +94,7 @@ private void loadAvatar(ContactUi contact) { | |||
| } | |||
| } | |||
|
|
|||
| static class ListDiffCallback extends DiffUtil.ItemCallback<ContactUi> { | |||
| /* static class ListDiffCallback extends DiffUtil.ItemCallback<ContactUi> { | |||
There was a problem hiding this comment.
Код лучше сразу удалять, а не комментить
Comment on lines
111
to
113
| public Object getChangePayload(@NonNull ContactUi oldItem, @NonNull ContactUi newItem) { | ||
| return newItem; | ||
| } |
There was a problem hiding this comment.
Заметь, что везде еще была вот такая функция getChangePayload. В твоей реализации BaseListDiffCallback эта функция не переопределена - а значит ты сделал изменение, которое возможно что-то сломает
Можно эту функцию переопределить в BaseListDiffCallback, чтоб ничего не ломать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
с богом