Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not output stdout err msg when timestamp parse error in metrics cmd #1482

Merged
merged 7 commits into from
Nov 9, 2024
Merged

fix: not output stdout err msg when timestamp parse error in metrics cmd #1482

merged 7 commits into from
Nov 9, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Nov 9, 2024 •
edited
Loading

What Changed

Evidence

Integration-Test

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the bug Something isn't working label Nov 9, 2024
@fukusuket fukusuket added this to the 2.19.0 milestone Nov 9, 2024
@fukusuket fukusuket self-assigned this Nov 9, 2024
@fukusuket
Copy link
Collaborator Author

fukusuket commented Nov 9, 2024 •
edited
Loading

@YamatoSecurity
Sorry... I have not been able to confirm that the problem has been fixed. I tried fixing the code that might be causing the issue. Could you confirm it with your data?🙏

@fukusuket fukusuket changed the title fix: not output stdout err msg when timestamp parse error in metrics fix: not output stdout err msg when timestamp parse error in metrics cmd Nov 9, 2024
@fukusuket fukusuket marked this pull request as ready for review November 9, 2024 08:08
YamatoSecurity
YamatoSecurity approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! The bug is fixed! Amazing job being able to fix it without logs to test!

@YamatoSecurity YamatoSecurity merged commit 23032ed into main Nov 9, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1479-fix-multiple-progress-bars branch November 9, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@fukusuket fukusuket

Labels
bug Something isn't working
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.

Bug: logon-summary and eid-metrics outputs multiple progress bars sometimes
2 participants
@fukusuket @YamatoSecurity