Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--timeline-start and --timeline-end do not work correctly with pivot-keywords-list command. #1151

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Fixed --timeline-start and --timeline-end do not work correctly with pivot-keywords-list command.

I would appreciate it if you could review when you have time.

@hitenkoku hitenkoku self-assigned this Jul 31, 2023
@hitenkoku hitenkoku added the bug Something isn't working label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (f049dd3) 83.17% compared to head (be30fb6) 83.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   83.17%   83.13%   -0.04%     
==========================================
  Files          26       26              
  Lines       22618    22628      +10     
==========================================
  Hits        18812    18812              
- Misses       3806     3816      +10     
Files Changed Coverage Δ
src/detections/configs.rs 66.15% <0.00%> (-0.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku Thank you so much for fixing this! I confirmed that it works now.

@hitenkoku hitenkoku merged commit 074b681 into main Aug 1, 2023
9 checks passed
@hitenkoku hitenkoku changed the title 1150 timeline start and timeline end do not work with pivot keywords list --timeline-start and --timeline-end do not work correctly with pivot-keywords-list command. Aug 1, 2023
@hitenkoku hitenkoku deleted the 1150-timeline-start-and-timeline-end-do-not-work-with-pivot-keywords-list branch August 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--timeline-start and timeline-end do not work with pivot-keywords-list
2 participants