fix mvc request method (#749)

XiaoMi · Nov 1, 2023 · dda0ee2 · dda0ee2
1 parent 79bcddb
commit dda0ee2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/jcommon/docean/pom.xml b/jcommon/docean/pom.xml
@@ -10,7 +10,7 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>docean</artifactId>
-    <version>1.4.0</version>
+    <version>1.4.1-SNAPSHOT</version>
 
     <properties>
         <netty.version>4.1.48.Final</netty.version>

diff --git a/jcommon/docean/src/main/java/com/xiaomi/youpin/docean/Mvc.java b/jcommon/docean/src/main/java/com/xiaomi/youpin/docean/Mvc.java
@@ -161,8 +161,14 @@ public void callService(MvcContext context, MvcRequest request, MvcResponse resp
 
     public void callMethod(MvcContext context, MvcRequest request, MvcResponse response, MvcResult<Object> result, HttpRequestMethod method) {
         Safe.run(() -> {
-            JsonElement arguments = gson.fromJson(new String(request.getBody()), JsonElement.class);
+            //GET、POST
+            String reqMethod = request.getMethod();
             String m = method.getHttpMethod();
+            if (!m.equalsIgnoreCase(reqMethod)) {
+                throw new IllegalArgumentException(String.format("unmatched request type:%s, expect:%s", reqMethod, m.toUpperCase()));
+            }
+
+            JsonElement arguments = gson.fromJson(new String(request.getBody()), JsonElement.class);
             MutableObject mo = getArgs(method, arguments, m);
             Safe.run(() -> context.setParams(arguments));
             JsonElement args = mo.getObj();

diff --git a/jcommon/pom.xml b/jcommon/pom.xml
@@ -261,7 +261,7 @@
                         </goals>
                         <configuration>
                             <executable>gpg</executable>
-                            <keyname>your-gpg-key</keyname>
+<!--                            <keyname>your-gpg-key</keyname>-->
                         </configuration>
                     </execution>
                 </executions>