Merge pull request #2590 from XiaoMi/hotfix/stories-code-standard

fix: stories code standard
XiaoMi · Sep 18, 2023 · 3c16b3b · 3c16b3b
2 parents 1fbf860 + bf8818e
commit 3c16b3b
Show file tree

Hide file tree

Showing 15 changed files with 143 additions and 152 deletions.
diff --git a/packages/ui/ellipsis-tooltip/stories/multiply-line.stories.tsx b/packages/ui/ellipsis-tooltip/stories/multiply-line.stories.tsx
@@ -6,7 +6,7 @@ import EllipsisTooltip from '../src'
  */
 export const MultiplyLine = () => {
   const textOverview =
-  '【译】孔子说：“学习并且不断温习，不也很愉快吗？远方来了朋友，不也很快乐吗？人家不了解我，我也不怨恨，不也是君子吗？”，【译】孔子说：“学习并且不断温习，不也很愉快吗？远方来了朋友，不也很快乐吗？人家不了解我，我也不怨恨，不也是君子吗？”'
+    '【译】孔子说：“学习并且不断温习，不也很愉快吗？远方来了朋友，不也很快乐吗？人家不了解我，我也不怨恨，不也是君子吗？”，【译】孔子说：“学习并且不断温习，不也很愉快吗？远方来了朋友，不也很快乐吗？人家不了解我，我也不怨恨，不也是君子吗？”'
 
   return (
     <>

diff --git a/packages/ui/form/stories/cascade.stories.tsx b/packages/ui/form/stories/cascade.stories.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable node/no-callback-literal */
 import React from 'react'
 import Form, { FormHelpers } from '../src'
 import Button from '@hi-ui/button'
@@ -201,7 +200,7 @@ export const Cascade = () => {
               }}
               onRemove={(file, fileList, index) => {
                 console.log('remove callback', file, fileList, index)
-                return new Promise((resolve, reject) => resolve(true))
+                return new Promise((resolve) => resolve(true))
               }}
               name={'files[]'}
               defaultFileList={[

diff --git a/packages/ui/form/stories/get-values.stories.tsx b/packages/ui/form/stories/get-values.stories.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable node/no-callback-literal */
 import React from 'react'
 import Form, { FormHelpers } from '../src'
 import Input from '@hi-ui/input'
@@ -37,9 +36,9 @@ export const GetValues = () => {
                 validator: (rule, value, callback) => {
                   const telReg = /^[1][3|4|5|6|7|8|9][0-9]{9}$/
                   if (!value) {
-                    callback('请输入手机号')
+                    callback(new Error('请输入手机号'))
                   } else if (!telReg.test(value)) {
-                    callback('请输入正确的手机号')
+                    callback(new Error('请输入正确的手机号'))
                   } else {
                     callback()
                   }

diff --git a/packages/ui/form/stories/nested-field.stories.tsx b/packages/ui/form/stories/nested-field.stories.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable node/no-callback-literal */
 import React from 'react'
 import Form, { FormHelpers } from '../src'
 import Input from '@hi-ui/input'
@@ -44,9 +43,9 @@ export const NestedField = () => {
                 validator: (rule, value, callback) => {
                   const telReg = /^[1][3|4|5|6|7|8|9][0-9]{9}$/
                   if (!value) {
-                    callback('请输入手机号')
+                    callback(new Error('请输入手机号'))
                   } else if (!telReg.test(value)) {
-                    callback('请输入正确的手机号')
+                    callback(new Error('请输入正确的手机号'))
                   } else {
                     callback()
                   }

diff --git a/packages/ui/form/stories/set-values.stories.tsx b/packages/ui/form/stories/set-values.stories.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable node/no-callback-literal */
 import React from 'react'
 import Form, { FormHelpers } from '../src'
 import Input from '@hi-ui/input'
@@ -51,9 +50,9 @@ export const SetValues = () => {
                     validator: (rule, value, callback) => {
                       const telReg = /^[1][3|4|5|6|7|8|9][0-9]{9}$/
                       if (!value) {
-                        callback('请输入手机号')
+                        callback(new Error('请输入手机号'))
                       } else if (!telReg.test(value)) {
-                        callback('请输入正确的手机号')
+                        callback(new Error('请输入正确的手机号'))
                       } else {
                         callback()
                       }

diff --git a/packages/ui/form/stories/validate-field.stories.tsx b/packages/ui/form/stories/validate-field.stories.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable node/no-callback-literal */
 import React from 'react'
 import Form, { FormHelpers } from '../src'
 import Input from '@hi-ui/input'
@@ -70,9 +69,9 @@ export const ValidateField = () => {
                   const telReg = /^[1][3|4|5|6|7|8|9][0-9]{9}$/
 
                   if (!value) {
-                    callback('请输入手机号')
+                    callback(new Error('请输入手机号'))
                   } else if (!telReg.test(value)) {
-                    callback('请输入正确的手机号')
+                    callback(new Error('请输入正确的手机号'))
                   } else {
                     callback()
                   }
@@ -94,9 +93,9 @@ export const ValidateField = () => {
                     validator: (rule, value, callback) => {
                       const telReg = /^[0-9]{6}$/
                       if (!value) {
-                        callback('请输入手机号')
+                        callback(new Error('请输入手机号'))
                       } else if (!telReg.test(value)) {
-                        callback('请输入正确的验证码')
+                        callback(new Error('请输入正确的验证码'))
                       } else {
                         callback()
                       }
@@ -135,9 +134,9 @@ export const ValidateField = () => {
                 validator: (rule, value, callback) => {
                   const telReg = /^(?![^a-zA-Z]+$)(?!\D+$).{8,16}$/
                   if (!value) {
-                    callback('请输入密码')
+                    callback(new Error('请输入密码'))
                   } else if (!telReg.test(value)) {
-                    callback('请输入包括数字和字母、长度8到16位的密码组合')
+                    callback(new Error('请输入包括数字和字母、长度8到16位的密码组合'))
                   } else {
                     callback()
                   }
@@ -159,7 +158,7 @@ export const ValidateField = () => {
                   console.log(value, formData.password)
 
                   if (value !== formData.password) {
-                    callback('两次密码不同')
+                    callback(new Error('两次密码不同'))
                   } else {
                     callback()
                   }

diff --git a/packages/ui/form/stories/validate.stories.tsx b/packages/ui/form/stories/validate.stories.tsx
@@ -86,13 +86,10 @@ export const Validate = () => {
         validator: (rule, value, cb) => {
           const count = +value
           if (isNaN(count)) {
-            // eslint-disable-next-line node/no-callback-literal
-            cb('请输入数字')
+            cb(new Error('请输入数字'))
           } else if (count <= 0) {
-            // eslint-disable-next-line node/no-callback-literal
-            cb('必须是正数')
+            cb(new Error('必须是正数'))
           } else {
-            // eslint-disable-next-line node/no-callback-literal
             cb()
           }
         },
@@ -155,7 +152,7 @@ export const Validate = () => {
           <FormItem label="品类" field="category" valueType="string">
             <Cascader
               onChange={(id) => {
-                console.log('change')
+                console.log('change', id)
               }}
               data={cascaderOptions}
               style={{ width: '100%' }}

diff --git a/packages/ui/message/stories/type.stories.tsx b/packages/ui/message/stories/type.stories.tsx
@@ -11,7 +11,7 @@ export const Type = () => {
     return () => {
       message.open({
         title: '问君能有几多愁，恰似一江春水向东流',
-        type: type,
+        type,
       })
     }
   }

diff --git a/packages/ui/scrollbar/stories/event.stories.tsx b/packages/ui/scrollbar/stories/event.stories.tsx
@@ -23,7 +23,7 @@ export const Event = () => {
       <h2>x、y滚动事件</h2>
       <div className="scrollbar-basic__wrap" style={{ height: 320, marginBottom: 64 }}>
         <Scrollbar
-          onScrollX={(e) => console.log('scroll x')}
+          onScrollX={() => console.log('scroll x')}
           onScrollY={() => console.log('scroll y')}
         >
           {scrollContent}