Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: air-conditioner switch on #88

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: air-conditioner switch on #88

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bff5b3b
fix: air-conditioner switch on
SusanPhevos Dec 17, 2024
dbf9433
fix: set prop
SusanPhevos Dec 17, 2024
da58d4c
perf: remove permanent true statement
SusanPhevos Dec 17, 2024
b7fc534
fix: bool value false
SusanPhevos Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions custom_components/xiaomi_home/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,18 @@ async def async_turn_off(self) -> None:

async def async_set_hvac_mode(self, hvac_mode: HVACMode) -> None:
"""Set new target hvac mode."""
if hvac_mode == HVACMode.OFF and self._prop_on:
# set air-conditioner off
if hvac_mode == HVACMode.OFF:
if not await self.set_property_async(
prop=self._prop_on, value=False):
raise RuntimeError(
f'set climate prop.on failed, {hvac_mode}, '
f'{self.entity_id}')
return
# set air-conditioner on
elif self.get_prop_value(prop=self._prop_on) is False:
await self.set_property_async(prop=self._prop_on, value=True)
# set mode
mode_value = self.get_map_value(
map_=self._hvac_mode_map, description=hvac_mode)
if (
Expand Down Expand Up @@ -366,7 +371,7 @@ def current_humidity(self) -> Optional[int]:
@ property
def hvac_mode(self) -> Optional[HVACMode]:
"""Return the hvac mode. e.g., heat, cool mode."""
if self._prop_on and self.get_prop_value(prop=self._prop_on) is False:
if self.get_prop_value(prop=self._prop_on) is False:
return HVACMode.OFF
return self.get_map_description(
map_=self._hvac_mode_map,
Expand Down
Loading