Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore undefined piid and keep processing following arguments #377

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

RangerCD
Copy link
Contributor

Fix #376

  • 忽略spec中未定义的piid并继续处理后续的arguments
  • 错误日志改为debug日志

@RangerCD RangerCD changed the title fix: ignore undefined piid and keep process following arguments fix: ignore undefined piid and keep processing following arguments Dec 23, 2024
@RangerCD RangerCD force-pushed the fix-ignore-undefined-piid branch from 9852e0f to 301ecf9 Compare December 23, 2024 03:19
@chemwolf6922
Copy link
Contributor

chemwolf6922 commented Dec 24, 2024

@topsworld I think you should also contact the PM or Hongyu to fix the broken spec to solve the original problem.

@RangerCD
Copy link
Contributor Author

@topsworld Should incomplete events be passed to the application? Will this cause problems?

If spec doesn't provide the definition of a piid, from intergration's perspective, it's something either redundant or unnecessary. Maybe it's a private argument used by Mijia App, and should be ignored by HA.

@topsworld
Copy link
Contributor

@topsworld I think you should also contact the PM or Hongyu to fix the broken spec to solve the original problem.

Done.

@topsworld topsworld merged commit 7654e5e into XiaoMi:main Dec 24, 2024
5 checks passed
@RangerCD RangerCD deleted the fix-ignore-undefined-piid branch December 25, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

米家吸顶灯D20持续产生雷达错误日志
4 participants