misc: remove tev dependency for lan control & fixs #333
+465
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemwolf6922
changed the title
chemwolf6922
changed the title
SusanPhevos
approved these changes
Dec 24, 2024
topsworld
approved these changes
Dec 25, 2024
topsworld
reviewed
Dec 25, 2024
| continue | ||
| lan_device.on_delete() | ||
|
|
||
| def __on_network_info_chnage(self, data: _MIoTLanNetworkUpdateData) -> None: |
| _LOGGER.info('no central service, init miot lan') | ||
| await self.init_async() | ||
|
|
||
| # The folowing methods SHOULD ONLY be called in the internal loop |
There was a problem hiding this comment.
spelling mistakes: folowing
| return self.__lan_send_cmd( | ||
| cmd=MIoTLanCmdType.UNREG_BROADCAST, | ||
| data=MIoTLanUnregisterBroadcastData(key=key)) | ||
| self._internal_loop.call_soon_threadsafe( |
There was a problem hiding this comment.
After deinit_async called, the program will stop internal loop and call the lan state change callback. When other services judge that the lan state changed, functions such as unsub_prop may be called, which may lead to RuntimeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change made
Lan and mips uses a python version of tev. Since asyncio is already used in the project, it is better to align the event loop to the same solution.
Changes
Tests
Please help test this in a more complex environment.