Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local ctrl error #271

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Fix local ctrl error #271

merged 8 commits into from
Dec 20, 2024

Conversation

topsworld
Copy link
Contributor

@topsworld topsworld commented Dec 20, 2024

Fixed

  • Add profile devices filter, fix local control error

Added

  • Add tools to update profle model file

Changed

  • Improve lan control test case

It is necessary to realize the logic of profile convert specv2 later, so as to realize local control and subscribe to the Profile device

@topsworld topsworld self-assigned this Dec 20, 2024
@topsworld topsworld marked this pull request as ready for review December 20, 2024 04:06
@chemwolf6922
Copy link
Contributor

Suggestion: Just use the specV2 subscription result. Do not dive into the profile pitfall (again).

@chemwolf6922
Copy link
Contributor

And the cloud has a field for telling if a device is "native spec V2" (for the central gateway). You should use that instead of any hard coded list.

@chemwolf6922
Copy link
Contributor

And this (newly added) timeout seems suspiciously small. Please check if this is by design.

NETWORK_UNSTABLE_RESUME_TH: int = 300

@chemwolf6922
Copy link
Contributor

Suggestion: Just use the specV2 subscription result. Do not dive into the profile pitfall (again).

Apparently there are device that supports the full subscription and also use the old protocol...

@topsworld
Copy link
Contributor Author

And this (newly added) timeout seems suspiciously small. Please check if this is by design.

NETWORK_UNSTABLE_RESUME_TH: int = 300

Is a bug 🫥

@topsworld
Copy link
Contributor Author

And the cloud has a field for telling if a device is "native spec V2" (for the central gateway). You should use that instead of any hard coded list.

The cloud interface provided does not have this field. This list contains the Profile device, and there will be no update in the future, so use HardCode

@topsworld topsworld merged commit bd3a98b into XiaoMi:main Dec 20, 2024
5 checks passed
@topsworld topsworld deleted the fix-local-ctrl-error branch December 20, 2024 11:21
@topsworld topsworld linked an issue Dec 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment