Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:add missing parameter state_class #101

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DoraTiger
Copy link

  1. add optional parameter for SPEC_PROP_TRANS_MAP, in order to add default state_class and unit:
{
    'entities':{
        '<entity name>':{
            'format': set<str>,
            'access': set<str>
        }
    },
    'properties': {
        '<property instance name>':{
            'device_class': str,
            'entity': str,
            'optional':{
                'state_class': str,
                'unit_of_measurement': str
            }
        }
    }
}
  1. Modify the relevant logic to adapt to parameter modifications.

Relation Issue: #30

@SusanPhevos
Copy link
Contributor

And #245

@SusanPhevos SusanPhevos self-requested a review December 24, 2024 12:42
@topsworld topsworld self-requested a review December 24, 2024 13:28
# optional:
optional = SPEC_PROP_TRANS_MAP['properties'][prop_name].get('optional')
if optional:
prop_optional_state_class = optional.get('state_class')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 'state_class' in optional:
result['state_class'] = optional['state_class']

The same logic below

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, and test pass in local ha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants