cleaned up code and redid angle bonuses #118
Test Results (macOS, MultiThreaded) ❌
❌ TestResults-macOS-MultiThreaded.trx
5510 tests were completed in 2102s with 5447 passed, 11 failed and 52 skipped.
Test suite | Passed | Failed | Skipped | Time |
---|---|---|---|---|
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest | 10❌ | 106ms | ||
osu.Game.Tests.Visual.Gameplay.TestScenePerformancePointsCounter | 2✔️ | 1❌ | 10s |
❌ osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest
❌ Test(0.14102693012101306d,2,"nan-slider")
Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
But was: 0.13529632558563595d
Off by: 0.005730604535377104d
❌ Test(0.4250648023083879d,4,"very-fast-slider")
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
❌ Test(1.4386882251130073d,54,"zero-length-sliders")
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
❌ Test(6.710442985146793d,239,"diffcalc-test")
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
❌ TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
❌ TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
❌ TestClassicMod(6.710442985146793d,239,"diffcalc-test")
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
❌ TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
But was: 0.53415238942585086d
Off by: 0.016558438578884282d
❌ TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
But was: 1.8375563953291101d
Off by: -0.094376177113883131d
❌ TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
But was: 8.4118506786801106d
Off by: 0.56244459162705596d
❌ osu.Game.Tests.Visual.Gameplay.TestScenePerformancePointsCounter
❌ TestBasicCounting
TearDown : System.TimeoutException : "counter non-zero" timed out
✔️ TestConstructor
✔️ TestCounterUpdatesWithJudgementsBeforeCreation
Annotations
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.14102693012101306d,2,"nan-slider")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
But was: 0.13529632558563595d
Off by: 0.005730604535377104d
Raw output
Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
But was: 0.13529632558563595d
Off by: 0.005730604535377104d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.4250648023083879d,4,"very-fast-slider")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
Raw output
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(1.4386882251130073d,54,"zero-length-sliders")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
Raw output
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(6.710442985146793d,239,"diffcalc-test")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
Raw output
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 23
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
Raw output
Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
But was: 0.40683105599053704d
Off by: 0.018233746317850852d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
Raw output
Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
But was: 1.4625987438071855d
Off by: -0.023910518694178151d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(6.710442985146793d,239,"diffcalc-test")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
Raw output
Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
But was: 5.9052296990599427d
Off by: 0.80521328608685039d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 35
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
But was: 0.53415238942585086d
Off by: 0.016558438578884282d
Raw output
Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
But was: 0.53415238942585086d
Off by: 0.016558438578884282d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
But was: 1.8375563953291101d
Off by: -0.094376177113883131d
Raw output
Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
But was: 1.8375563953291101d
Off by: -0.094376177113883131d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
But was: 8.4118506786801106d
Off by: 0.56244459162705596d
Raw output
Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
But was: 8.4118506786801106d
Off by: 0.56244459162705596d
at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
1) at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in /Users/runner/work/osu/osu/osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs:line 31
at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in /Users/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/OsuDifficultyCalculatorTest.cs:line 29
Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (macOS, MultiThreaded)
osu.Game.Tests.Visual.Gameplay.TestScenePerformancePointsCounter ► TestBasicCounting
Failed test found in:
TestResults-macOS-MultiThreaded.trx
Error:
TearDown : System.TimeoutException : "counter non-zero" timed out
Raw output
TearDown : System.TimeoutException : "counter non-zero" timed out
--TearDown
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
at osu.Framework.Testing.TestScene.RunTestsFromNUnit()