Fix MinecraftInstanceParser

Xcube-Studio · Sep 3, 2024 · 3bb5197 · 3bb5197
1 parent f22d957
commit 3bb5197
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Natsurainko.FluentCore/GameManagement/Installer/Data/OptiFineInstallData.cs b/Natsurainko.FluentCore/GameManagement/Installer/Data/OptiFineInstallData.cs
@@ -14,5 +14,5 @@ public class OptiFineInstallData
     public required string FileName { get; set; }
 
     [JsonPropertyName("forge")]
-    public required string ForgeVersion { get; set; }
+    public string? ForgeVersion { get; set; }
 }
diff --git a/Natsurainko.FluentCore/GameManagement/Instances/MinecraftInstanceParser.cs b/Natsurainko.FluentCore/GameManagement/Instances/MinecraftInstanceParser.cs
@@ -21,13 +21,13 @@ public class MinecraftInstanceParser
     /// Successfully parsed instances
     /// </summary>
     public IReadOnlyCollection<MinecraftInstance> ParsedInstances => _parsedInstances;
-    private readonly List<MinecraftInstance> _parsedInstances = new();
+    private readonly List<MinecraftInstance> _parsedInstances = [];
 
     /// <summary>
     /// Erroneous directories that failed to parse
     /// </summary>
     public IReadOnlyCollection<DirectoryInfo> ErroneousDirectories => _erroneousDirectories;
-    private readonly List<DirectoryInfo> _erroneousDirectories = new();
+    private readonly List<DirectoryInfo> _erroneousDirectories = [];
 
     // .minecraft folder path
     private readonly string _minecraftFolderPath;
@@ -48,6 +48,9 @@ public MinecraftInstanceParser(string minecraftFolderPath)
     /// <returns>All Minecraft instances parsed in this .minecraft profile</returns>
     public IReadOnlyCollection<MinecraftInstance> ParseAllInstances()
     {
+        _parsedInstances.Clear();
+        _erroneousDirectories.Clear();
+
         var versionsDirectory = new DirectoryInfo(Path.Combine(_minecraftFolderPath, "versions"));
 
         if (!versionsDirectory.Exists)