-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Implement non-jax versions of IQP models #6
Open
mariaschuld
wants to merge
100
commits into
main
Choose a base branch
from
hpc-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariaschuld
commented
Feb 28, 2024
mariaschuld
commented
Feb 28, 2024
@@ -132,15 +139,19 @@ def precompute_kernel(self, X1, X2): | |||
dim2 = len(X2) | |||
|
|||
# concatenate all pairs of vectors | |||
Z = jnp.array( | |||
Z = np.array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pure numpy because we're not differentiating through the construction of the kernel matrix...
mariaschuld
changed the title
[WIP] Implement non-jax versions of IQP models
[Do not merge] Implement non-jax versions of IQP models
Feb 29, 2024
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick-and-dirty implementation to add hyperparameters
use_jax
andvmap
toIQPVariationalCircuit
andIQPKernelClassifier
. Together with the existingjit
hyperparameter, we can toggle between these options:This is useful to test PennyLane's lightning backends as well as Catalyst with two examples of the QML benchmarking code base.
In
IQPKernelClassifier
, jax, jitting and vmapping is only meaningfully used in the computation of the entries of a kernel matrix, not in optimisation (which is done by scikit-learn and very quick). InIQPVariationalClassifier
, jax, jitting and vmapping defines the optimisation procedure, and an option for optimisation based on PennyLane's autograd interface had to be added.I tested the new logic in the following two non-exhaustive ways:
jax
orjnp
are only ever used withinif self.use_jax
blocks.This was the example:
Results: