-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generative models and datasets #34
Open
josephbowles
wants to merge
61
commits into
main
Choose a base branch
from
generative_models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the generative models branch with main
Updated spin blobs dataset
Added models for generative learning and scripts to perform hyperparameter search on them.
Add models for generative learning and hyper parameter search
hyperparameter script working with generative models
josephbowles
changed the title
Generative models update
Add generative models and datasets
Oct 10, 2024
josephbowles
requested review from
quantshah and
mariaschuld
and removed request for
quantshah
October 10, 2024 15:31
mariaschuld
reviewed
Oct 14, 2024
mariaschuld
reviewed
Oct 14, 2024
mariaschuld
reviewed
Oct 14, 2024
mariaschuld
reviewed
Oct 14, 2024
mariaschuld
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, but overall good to go! Thanks for making the changes, and nice to see that it wasn't overly painful to extend the scope of the repo...
Co-authored-by: Maria Schuld <[email protected]>
Co-authored-by: Maria Schuld <[email protected]>
Co-authored-by: Maria Schuld <[email protected]>
Co-authored-by: Maria Schuld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update to the repo to include new generative models and datasets.
New Models
Both models can be scored using the maximum mean discrepancy distance.
New dataset generating functions
These are designed for generative learning
Backwards compatibility
All code from the previous version of the repo should work identically. Training and hyperparameter optimization scripts have been updated accordingly to handle generative models. As a general rule, we specify the model is generative by using y=None in place of labels.
future changes
The repo does not contain any quantum generative models at the moment; it would be good to add a simple example. There is also no changes to the folder structure, so e.g. classifier and generative models are stored in the same directory. It may make sense to change this structure to account for the classifier/generative dichotomy going forward.