Reenabling tests for the UI projects in CI #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
github_actions
|
@dotnet-policy-service agree |
sungam3r
reviewed
Apr 27, 2023
test/HealthChecks.UI.Tests/Functional/Configuration/UIHttpMessageHandlerTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 27, 2023
| @@ -60,11 +60,17 @@ jobs: | |||
| 6.0.x | |||
| 7.0.x | |||
| - name: Restore UI | |||
There was a problem hiding this comment.
Let's join all restore commands into one step with name Restore.
sungam3r
reviewed
Apr 27, 2023
| run: dotnet format --no-restore --verify-no-changes --severity warn ./src/HealthChecks.UI/HealthChecks.UI.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1) | ||
| run: | | ||
| dotnet format --no-restore --verify-no-changes --severity warn ./src/HealthChecks.UI/HealthChecks.UI.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1) && | ||
| dotnet format --no-restore --verify-no-changes --severity warn ./test/HealthChecks.UI.Tests/HealthChecks.UI.Tests.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1) | ||
| - name: Check formatting UI.Client |
There was a problem hiding this comment.
The same suggestion for that step - use Check formatting name.
sungam3r
reviewed
Apr 27, 2023
| @@ -102,13 +114,17 @@ jobs: | |||
| run: dotnet format --no-restore --verify-no-changes --severity warn ./src/HealthChecks.UI.K8s.Operator/HealthChecks.UI.K8s.Operator.csproj || (echo "Run 'dotnet format' to fix issues" && exit 1) | |||
|
|
|||
| - name: Build UI | |||
sungam3r
reviewed
Apr 27, 2023
| # flags: UI | ||
| # directory: .coverage | ||
|
|
||
| - name: Test UI |
There was a problem hiding this comment.
And again - one step with name Test and && to chain calls to dotnet test.
…ageHandlerTests.cs Co-authored-by: Ivan Maximov <[email protected]>
sungam3r
reviewed
Apr 29, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1807 +/- ##
==========================================
+ Coverage 66.26% 66.96% +0.70%
==========================================
Files 145 212 +67
Lines 3910 7744 +3834
Branches 388 527 +139
==========================================
+ Hits 2591 5186 +2595
- Misses 1230 2422 +1192
- Partials 89 136 +47
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@rob-baldwin Thank you very much. |
sungam3r
approved these changes
Apr 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CI tests were not running for the UI projects, this PR makes minimal changes to get the UI tests to run again.
Which issue(s) this PR fixes:
Mentioned as a pain point in: #1714
Special notes for your reviewer:
I've disabled one test, as I could not figure out why it was failing and guessed it was more important to have the majority of tests running than none.
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: