Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Microsoft.Bcl.AsyncInterfaces to allow EventStore.gRPC to work on net6.0 #1720

Merged

Conversation

NielsPilgaard
Copy link
Contributor

Added Microsoft.Bcl.AsyncInterfaces to allow EventStore.gRPC to work on net6.0

What this PR does / why we need it:
The 7.0.0 versions of EventStore gRPC do not work on net6.0 at the moment: #1692 (comment)

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@sungam3r sungam3r added the dependencies Pull requests that update a dependency file label Mar 1, 2023
@sungam3r sungam3r merged commit 8ec597b into Xabaril:master Mar 1, 2023
@NielsPilgaard NielsPilgaard deleted the bugfix/eventstore-grpc-dotnet6-compat branch March 1, 2023 16:45
@NielsPilgaard
Copy link
Contributor Author

Thanks 👍 Do you have an idea as to when you'll release this?

@sungam3r
Copy link
Collaborator

sungam3r commented Mar 1, 2023

I can push preview ASAP if you want. As for release see #1593 (comment)

@NielsPilgaard
Copy link
Contributor Author

Yes please, that'd be nice :)

@sungam3r
Copy link
Collaborator

sungam3r commented Mar 1, 2023

@sungam3r
Copy link
Collaborator

sungam3r commented Mar 1, 2023

Pushing AspNetCore.HealthChecks.EventStore.gRPC.7.0.0-rc2.4.nupkg to 'https://www.nuget.org/api/v2/package'...
  PUT https://www.nuget.org/api/v2/package/
warn : Readme missing. Go to https://aka.ms/nuget-include-readme learn How to include a readme file within the package.
  Created https://www.nuget.org/api/v2/package/ 912ms
Your package was pushed.

Wait 1-5 minutes because nuget needs to index package.

@NielsPilgaard
Copy link
Contributor Author

AspNetCore.HealthChecks.EventStore.gRPC.7.0.0-rc2.4 does fix the issue 👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eventstore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants