-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rows to parameters column for text type #667
Conversation
7aaacf5
to
d3e6917
Compare
d3e6917
to
c47ed44
Compare
I mean, OK, but that's a bit flippant. You could say whether or not you followed the existing patterns for parameters (and why), whether or not you searched for other issues that might overlap with the linked issue, whether or not you tested the XForm output with Collect and/or Enketo, etc. I often use PR descriptions, issues, and commit messages to do code archaeology to understand why things are a certain way, so adding some detail is worth the effort even if it seems obvious now. |
Yeah, that makes sense. Even if something is obvious adding a short description might be valuable for other devs. |
@grzesiek2010 thanks! |
Closes #616
Why is this the best possible solution? Were any other approaches considered?
The solution is consistent with how we handle other parameters in other question types. In My previous pull request, I added a new parameter for image questions (see #659) and this one solves the problem in the same way. I haven't considered any other approaches. I know there is a plan to Create a framework for adding parameters and then the solution would be different but for now we should follow the existing patterns.
What are the regression risks?
This is not a risky change. It's isolated and touches only reading parameters used in text questions.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes: XLSForm/xlsform.github.io#254
Before submitting this PR, please make sure you have:
tests
nosetests
and verified all tests passblack pyxform tests
to format code