Add accuracy parameters for geopoint #586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #579
Why is this the best possible solution? Were any other approaches considered?
This is the approach that matches other parameters currently. I feel more and more of a desire to reduce the spaghetti nature of that part of the code but I don't think we should combine that with adding a new parameter.
What are the regression risks?
I had to combine this with
allow-mock-accuracy
which also applies togeopoint
questions. So there's some risk there. I added test to verify that the new attributes aren't allowed with trace/shape and that all of the point parameters combine well.Does this change require updates to documentation? If so, please file an issue here and include the link below.
XLSForm/xlsform.github.io#222
Before submitting this PR, please make sure you have:
tests
nosetests
and verified all tests passblack pyxform tests
to format code