Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy parameters for geopoint #586

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

lognaturel
Copy link
Contributor

Closes #579

Why is this the best possible solution? Were any other approaches considered?

This is the approach that matches other parameters currently. I feel more and more of a desire to reduce the spaghetti nature of that part of the code but I don't think we should combine that with adding a new parameter.

What are the regression risks?

I had to combine this with allow-mock-accuracy which also applies to geopoint questions. So there's some risk there. I added test to verify that the new attributes aren't allowed with trace/shape and that all of the point parameters combine well.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

XLSForm/xlsform.github.io#222

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run nosetests and verified all tests pass
  • run black pyxform tests to format code
  • verified that any code or assets from external sources are properly credited in comments

@lognaturel
Copy link
Contributor Author

The goal would be to get this in a new pyxform release by Tuesday 2/15!

pyxform/xls2json.py Outdated Show resolved Hide resolved
pyxform/xls2json.py Outdated Show resolved Hide resolved
tests/test_allow_mock_accuracy.py Show resolved Hide resolved
@lindsay-stevens
Copy link
Contributor

Looks good! Just a suggestion about the warning message, but it's not really a blocker.

@lognaturel lognaturel merged commit dd4e366 into XLSForm:master Feb 10, 2022
@lognaturel lognaturel deleted the accuracy-params branch February 10, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accuracyThreshold and unacceptableAccuracyThreshold as parameters for geopoint
2 participants