Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety #54

Merged
merged 12 commits into from
Apr 12, 2023
Merged

Null safety #54

merged 12 commits into from
Apr 12, 2023

Conversation

timothysteward-wk
Copy link
Contributor

Motivation

This PR migrates the repo to enable null safety.

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

tool/dart_dev/config.dart Outdated Show resolved Hide resolved
lib/src/events.dart Outdated Show resolved Hide resolved
lib/src/client.dart Show resolved Hide resolved
@@ -105,74 +105,74 @@ void _integrationSuite(
SockJSClient createCorClient(),
SockJSClient create404Client(),
) {
SockJSClient client;
SockJSClient? client;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this late instead of nullable to avoid all the !s below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but we explicitly make it null in the tear down. It seems like we should this so we don't get weird behavior with the client sticking around if we forget to set it in one of the tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me sort of wish tests were class-based so that you didn't have to deal with scoping that exists beyond the test's lifecycle.

Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1 CI passes and manual consumer tests pass

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 9127f5c into master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants