Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added comments for translators #472

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

mehrazmorshed
Copy link
Contributor

added comments for translators in multiple files

Copy link
Collaborator

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the comments looks good to me.

I haven't found a specific docs about this but for consistency with this plugin codebase and with WordPress core I think the comments should have the multiline format (/* translators: Hi! */) and not the single line one ( // translators: Hi! ).

Examples from this repo:
https://github.com/search?q=repo%3AWordPress%2Ftheme-check%20translators&type=code

Examples from core:
https://github.com/search?q=repo%3AWordPress%2Fwordpress-develop%20translators&type=code

@mehrazmorshed
Copy link
Contributor Author

Hi, @matiasbenedetto,

Thank you for the feedback and for pointing out the examples for consistency.

I have updated the comments to use the multiline format (/* translators: */) as suggested.

Please let me know if there’s anything else I should address!

Copy link
Collaborator

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matiasbenedetto matiasbenedetto merged commit b2b4cec into WordPress:master Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants