Accurate sizes: Use block context approach #1625
Conversation
mukeshpanchal27
added
[Type] Enhancement
…ors' into update/use-filter-approach
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
|
We are tracking the unit test issue here #1634 |
| return $content; | ||
| } | ||
| add_filter( 'render_block_core/image', 'auto_sizes_filter_image_tag', 10, 2 ); | ||
| add_filter( 'render_block_core/cover', 'auto_sizes_filter_image_tag', 10, 2 ); | ||
| add_filter( 'the_content', 'auto_sizes_prime_attachment_caches', 6 ); |
There was a problem hiding this comment.
Curious as to why priority 6 is used?
There was a problem hiding this comment.
Priority 6 is used to ensure the new filter runs right after the wp-image-$attachment_id class is added to the img tag at priority 5, allowing modifications that rely on this class being in place.
There was a problem hiding this comment.
Cool. Probably good to add a comment to explain why that number was chosen.
There was a problem hiding this comment.
LGTM, although @joemcgill would know better what to look for in what this is seeking to achieve.
Summary
These PR updates the existing code to use the new block context approach that we discussed in #1511 (comment)