Show the starter content pattern category on page creation #68806
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +34 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
I tried some similar changes myself and what most bothered me is the case where "Starter content" does not exist. On trunk, due to happenstance, the "All" category is shown. On this branch, the blank pattern preview you mention shows up. (screenshot disclosed)
If we aren’t going to revert to the modal, I suppose this is acceptable. The modal however doesn’t have this problem because it only presents if/when the "Starter content" category is available.
What complicates the idea to catch missing/invalid categories is that it may be temporary. At least in the case of "core/starter-content", the category is always absent in the initial render and may or may not become available. I didn’t find a simple way to account for this. How long it takes to show up depends on network conditions. |
|
Even if the modal is used instead, there is still a problem with passing any category to the pattern preview in an unexpected format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I would like the approach to be discussed before this is is merged because I am not certain this is the best way to solve the problem.
In the pattern category preview, the expected format of the category is an object with a
nameandlabelparameter.However, in the components that pass the category to the previewer, the category is a string.
The
ZoomOutModeInserterButtonpasses the value "all" -and this is not recognized as a category by the previewer.The previewer is expecting the name parameter with the value "allPatterns":
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/inserter/block-patterns-tab/utils.js#L18
The
StartPageOptionspasses the value "core/starter-content" and the previewer is expecting the name parameter with this value.So what this PR does is:
name, so that the previewer receives the correct identifier for the categoryThis is what I have tried so far.
But what this does not do, is guard against missing, invalid, categories.
If the value is a pattern category that does not exist, then the pattern preview panel opens, but it is empty:
I believe that if the pattern category does not exist, there should be a notice about it, or all patterns should show.
The reason why I am hesitating to add this, is because I am not sure where in the code the validation needs to happen.
Perhaps in packages/block-editor/src/components/inserter/menu.js? Or in the pattern preview component?
Partial for #68736
Alternative to #68801
Testing Instructions
Activate a block theme that has starter content patterns, for example Twenty Twenty-Five.
Create a new page and observe which pattern category that is shown in the inserter sidebar.
Edit a template and observe which pattern category that is shown when adding a pattern in zoom out mode.
Screenshots or screencast