Merge pull request #317 from ocean90/fix/array-filter-data

Unset references to prevent data corruption
Wixel · Dec 13, 2020 · e8416a3 · e8416a3
2 parents 3c94b7c + 18c6e37
commit e8416a3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/gump.class.php b/gump.class.php
@@ -916,6 +916,8 @@ public function filter(array $input, array $filterset)
                 foreach ($input_array as &$value) {
                     $value = $this->call_filter($parsed_rule['rule'], $value, $parsed_rule['param']);
                 }
+
+                unset($input_array, $value);
             }
         }
 

diff --git a/tests/FilterTest.php b/tests/FilterTest.php
@@ -131,6 +131,22 @@ public function testItForwardsParametersToNativePHPFunctions()
         $this->assertTrue(password_verify('my_password', $result['field']));
     }
 
+    public function testArrayDataIsNotOverridden()
+    {
+        $result = $this->gump->filter([
+            'field_one' => ['100a', '200'],
+            'field_two' => 'yes',
+        ], [
+            'field_one' => 'sanitize_numbers',
+            'field_two' => 'boolean',
+        ]);
+
+        $this->assertEquals([
+            'field_one' => ['100', '200'],
+            'field_two' => true,
+        ], $result);
+    }
+
 //    public function testNestedArrays()
 //    {
 //        $data = [
@@ -169,4 +185,4 @@ public function testItForwardsParametersToNativePHPFunctions()
 //            ]
 //        ], $result);
 //    }
-}
+}