Add pronoun tags #281
Draft
Add pronoun tags #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no ui for this, so you have to manually edit the config to add them someone please do the ui for me because i do not feel like touching screens long enough to add this localization is going to be horrible 🫠
I can think of some translations, but not all. Anyways. It's subtile, but a nice feature. |
|
Caution I found a crash If you put it ("pronouns": ["she"]) as lowercase and press f5 (because I had the see own nametag enabled) you crash. If this feature is going to use cloud sync it can be used to initanily crash people, because you don't crash yourself Also this took me more then 1 hour to setup |
yes, known issue - the config around this is somewhat brittle right now and could definitely do with a lot of extra work, but its not one of my priorities right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?
What changes does this PR make?
Adds optional pronouns to name tags alongside the existing contributor nametags
Example
Anything else we should know?
This is currently in a "it functions but isn't really usable" state, as there's no way to modify this from the UI, but instead currently requires modifying the config (since I don't want to deal with touching screens long enough to change this
someone please do this for me).As such, this is currently more of a "request for comment" PR to see if this would be wanted.
Localizing this is also going to be a nightmare 🫠