Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Class property for contact sensor #321

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

supby
Copy link

@supby supby commented Nov 11, 2021

PR contains:

  • Contact property moved to separate property class
  • Contact property is reverted as Open means no contact
  • Class properties moved to separate files to increase readability of zigbee2mqtt class

@supby
Copy link
Author

supby commented Jan 27, 2022

@dhylands @lightsofapollo @mrstegeman @flatsiedatsie could somebody take a look on the PR? :)

@flatsiedatsie
Copy link
Contributor

flatsiedatsie commented Jan 28, 2022

I don't really work on this addon, I work on the Zigbee2MQTT one instead.

@supby
Copy link
Author

supby commented Jan 29, 2022

I'm using this addon exactly with z2m to show data from mqtt.

@flatsiedatsie
Copy link
Contributor

Sorry for the confusion: I'm talking about the Zigbee2MQTT addon (which comes with Z2M built-in, but can also be used with external Z2M).

I did take a quick look at your code and noticed that the first commit seems to change all the code (perhaps an indentation issue), which made it difficult to see what had changed there. Adding this 'reversability' feature seems to be the main change?

You also moved some code into separate files?

@supby
Copy link
Author

supby commented Jul 31, 2022

@flatsiedatsie Sorry for so late answer :)
Yes the PR introduces main two things:

  1. Structure code to the separate files
  2. Introduce new Meta property "ContactProperty" as reverse of OpenProperty. With OpenProperty aquara door sensors were open in closed (contact) state.

I tried to use https://github.com/kabbi/zigbee2mqtt-adapter adapter but seems it is to complex for my needs. I just need to interpret z2m messages to webthings. zigbee2mqtt-adapter didn't work for me.

@benfrancis benfrancis requested a review from tim-hellhake August 1, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants