-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Class property for contact sensor #321
base: master
Are you sure you want to change the base?
Conversation
Feature/contact prop refactoring
@dhylands @lightsofapollo @mrstegeman @flatsiedatsie could somebody take a look on the PR? :) |
I don't really work on this addon, I work on the Zigbee2MQTT one instead. |
I'm using this addon exactly with z2m to show data from mqtt. |
Sorry for the confusion: I'm talking about the Zigbee2MQTT addon (which comes with Z2M built-in, but can also be used with external Z2M). I did take a quick look at your code and noticed that the first commit seems to change all the code (perhaps an indentation issue), which made it difficult to see what had changed there. Adding this 'reversability' feature seems to be the main change? You also moved some code into separate files? |
@flatsiedatsie Sorry for so late answer :)
I tried to use https://github.com/kabbi/zigbee2mqtt-adapter adapter but seems it is to complex for my needs. I just need to interpret z2m messages to webthings. zigbee2mqtt-adapter didn't work for me. |
PR contains: