Apply new overflow menu design - closes #3104 #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hellhake
approved these changes
Aug 28, 2023
benfrancis
force-pushed
the
overflow-menu2
branch
from
e59cc8f to
f41cbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (just the second commit) applies the new overflow menu design from #3099 to the thing detail view log detail view.
This PR depends on #3099 and will need re-basing once that lands.
I wanted to go further than this by changing anchors into buttons and separating the shared overflow menu out into separate declarative elements in each view. But that sent me down a bit of a rabbit hole which uncovered a bunch of other issues like #3103, so I've kept the changes minimal for now. Mainly just CSS.
Closes #3104.