move error resource to its own interface. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons for this design change: it is confusing having one type named stream/stream-error and another named stream/error. this error resource seems useful outside of just streams. Therefore, we are moving it to a separate interface error in the same package. There are no functional changes to this type. The doc comments are now more general.
pchickey
force-pushed
the
pch/error_in_separate_interface
branch
from
4792310
to
6127a35
Compare
lukewagner
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two reasons for this design change:
stream/stream-errorand another namedstream/error.Therefore, we are moving it to a separate interface
errorin the same package. There are no functional changes to this type.The doc comments are now more general.