fix: react native buffer toString issue #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshuchawla009
approved these changes
Jun 5, 2024
src/mpcCoreKit.ts
Outdated
| @@ -1200,7 +1200,8 @@ export class Web3AuthMPCCoreKit implements ICoreKit { | |||
| } | |||
|
|
|||
| if (tssPubKey.length === FIELD_ELEMENT_HEX_LEN + 1) { | |||
| tssPubKey = tssPubKey.subarray(1); | |||
| // Buffer is needed as react native buffer polyfill not able to polyfill subarray function | |||
| tssPubKey = Buffer.from(tssPubKey.subarray(1)); | |||
There was a problem hiding this comment.
Hm, I’m trying to understand what is the issue in more detail here. You state that subarray function is not available on react native polyfill, but you still use it here? How does wrapping with Buffer.from resolve the issue?
|
add issue reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix react-native toString issue on buffer return from subarray() function
#152