Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, update to use the iPhone 12 simulator. #290

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Jan 21, 2021

Bitrise stack is updated, FB snapshot images as well. Let's see how CI likes this run.

This might be related: uber/ios-snapshot-test-case#109

@AvdLee AvdLee requested a review from Boris-Em as a code owner January 21, 2021 08:57
@AvdLee AvdLee self-assigned this Jan 21, 2021
@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Jan 21, 2021

Warnings
⚠️ Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')
⚠️

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.1, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'FBSnapshotTestCase iOS' from project 'FBSnapshotTestCase')

⚠️

WeScan/Extensions/CIImage+Utils.swift#L16 - 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)

⚠️

WeScan/Scan/CaptureSessionManager.swift#L262 - 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0

Messages
📖

View more details on Bitrise

📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 24.154 (24.240) seconds

WeScanTests.xctest: Coverage: 98.33

File Coverage
VisionRectangleDetectorTests.swift 99.29%
CIRectangleDetectorTests.swift 100.0%
UIImageTests.swift 100.0%

Generated by 🚫 Danger Swift against b23933b

@AvdLee AvdLee merged commit 575f006 into master Jan 21, 2021
@AvdLee AvdLee deleted the feature/fix-ci branch January 21, 2021 10:39
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.1 🚀

Generated by GitBuddy

@david6p2
Copy link

david6p2 commented Aug 4, 2021

@AvdLee did this fix the error with FB snapshot images appearing gray in CI or did you found another workaround?

@AvdLee
Copy link
Contributor Author

AvdLee commented Aug 9, 2021

@AvdLee did this fix the error with FB snapshot images appearing gray in CI or did you found another workaround?

It's been a while, I'm not sure. It at least fixed CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants