Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add playerID validation #663

Merged
merged 2 commits into from
Oct 21, 2023
Merged

add playerID validation #663

merged 2 commits into from
Oct 21, 2023

Conversation

JamesPHoughton
Copy link
Collaborator

No description provided.

@github-actions
Copy link 

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/ListSorter.jsx
  4:19  error  Useless path segments for "../components/TextStyles", should be "./TextStyles"  import/no-useless-path-segments

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
  143:55  error    'relTime' was used before it was defined  no-use-before-define
  171:7   warning  Unexpected alert                          no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Element.jsx
  10:3  error  'usePlayer' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  13:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/assignPositions.js
  1:10  error  'error' is defined but never used  no-unused-vars
  1:17  error  'warn' is defined but never used   no-unused-vars
  1:29  error  'log' is defined but never used    no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/callbacks.js
  37:23  error  'ctx' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/dispatch.js
  5:10  error  'error' is defined but never used  no-unused-vars
  5:29  error  'log' is defined but never used    no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/etherpad.js
  5:29  error  'log' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportParticipantData.js
  3:17  error  'warn' is defined but never used  no-unused-vars
  3:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportPaymentData.js
  2:17  error  'warn' is defined but never used                no-unused-vars
  2:29  error  'log' is defined but never used                 no-unused-vars
  6:11  error  'batchName' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportScienceData.js
  2:29  error  'log' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
  4:1   error  'axios' import should occur before import of './utils'                   import/order
  6:1   error  '@empirica/core/console' import should occur before import of './utils'  import/order
  6:10  error  'error' is defined but never used                                        no-unused-vars
  6:17  error  'warn' is defined but never used                                         no-unused-vars
  6:29  error  'log' is defined but never used                                          no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/github.js
   4:29  error  'log' is defined but never used              no-unused-vars
  87:11  error  'result' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/meetingRoom.js
  2:17  error  'warn' is defined but never used  no-unused-vars
  2:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preregister.js
  4:1   error  '@empirica/core/console' import should occur before import of './github'  import/order
  4:17  error  'warn' is defined but never used                                          no-unused-vars
  4:29  error  'log' is defined but never used                                           no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/qualtricsFetch.js
  2:17  error  'warn' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/utils.js
  4:17  error  'warn' is defined but never used  no-unused-vars
  4:23  error  'info' is defined but never used  no-unused-vars
  4:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/validateConfig.js
  8:10  error  'error' is defined but never used  no-unused-vars
  8:29  error  'log' is defined but never used    no-unused-vars

✖ 38 problems (37 errors, 1 warning)
  4 errors and 0 warnings potentially fixable with the '--fix' option.

@cypress
Copy link

cypress bot commented Oct 20, 2023 •
edited
Loading

Passing run #1172 ↗︎

0 14 0 0 Flakiness 0

Details:

test input validation
Project: Deliberation Commit: 70b365374f
Status: Passed Duration: 09:00 💡
Started: Oct 21, 2023 6:41 PM Ended: Oct 21, 2023 6:50 PM

Review all test suite changes for PR #663 ↗︎

@github-actions
Copy link 

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/ListSorter.jsx
  4:19  error  Useless path segments for "../components/TextStyles", should be "./TextStyles"  import/no-useless-path-segments

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
  143:55  error    'relTime' was used before it was defined  no-use-before-define
  171:7   warning  Unexpected alert                          no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Element.jsx
  10:3  error  'usePlayer' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  13:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/assignPositions.js
  1:10  error  'error' is defined but never used  no-unused-vars
  1:17  error  'warn' is defined but never used   no-unused-vars
  1:29  error  'log' is defined but never used    no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/callbacks.js
  37:23  error  'ctx' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/dispatch.js
  5:10  error  'error' is defined but never used  no-unused-vars
  5:29  error  'log' is defined but never used    no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/etherpad.js
  5:29  error  'log' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportParticipantData.js
  3:17  error  'warn' is defined but never used  no-unused-vars
  3:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportPaymentData.js
  2:17  error  'warn' is defined but never used                no-unused-vars
  2:29  error  'log' is defined but never used                 no-unused-vars
  6:11  error  'batchName' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/exportScienceData.js
  2:29  error  'log' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
  4:1   error  'axios' import should occur before import of './utils'                   import/order
  6:1   error  '@empirica/core/console' import should occur before import of './utils'  import/order
  6:10  error  'error' is defined but never used                                        no-unused-vars
  6:17  error  'warn' is defined but never used                                         no-unused-vars
  6:29  error  'log' is defined but never used                                          no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/github.js
   4:29  error  'log' is defined but never used              no-unused-vars
  87:11  error  'result' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/meetingRoom.js
  2:17  error  'warn' is defined but never used  no-unused-vars
  2:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preregister.js
  4:1   error  '@empirica/core/console' import should occur before import of './github'  import/order
  4:17  error  'warn' is defined but never used                                          no-unused-vars
  4:29  error  'log' is defined but never used                                           no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/qualtricsFetch.js
  2:17  error  'warn' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/utils.js
  4:17  error  'warn' is defined but never used  no-unused-vars
  4:23  error  'info' is defined but never used  no-unused-vars
  4:29  error  'log' is defined but never used   no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/validateConfig.js
  8:10  error  'error' is defined but never used  no-unused-vars
  8:29  error  'log' is defined but never used    no-unused-vars

✖ 38 problems (37 errors, 1 warning)
  4 errors and 0 warnings potentially fixable with the '--fix' option.

@JamesPHoughton JamesPHoughton linked an issue Oct 21, 2023 that may be closed by this pull request
Add check that platformID is valid #661
Closed
@JamesPHoughton JamesPHoughton merged commit e8abc0f into main Oct 21, 2023
2 checks passed
@JamesPHoughton JamesPHoughton deleted the james-validate-playerIDs branch October 21, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check that platformID is valid
1 participant
@JamesPHoughton