Skip to content

Commit

Permalink
netplay: clarify the behavior of GenericSystemErrorCategory
Browse files Browse the repository at this point in the history
For OSes other than Windows, it uses `strerror()`, which
is influenced by `LC_MESSAGES` system locale category.

Extend the comment in `GenericSystemErrorCategory` to reflect
that.

Signed-off-by: Pavel Solodovnikov <[email protected]>
  • Loading branch information
ManManson authored and past-due committed Oct 21, 2024
1 parent 1eb326f commit f520ccf
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/netplay/error_categories.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
///
/// Please see the bug https://github.com/microsoft/STL/issues/3254 for the explanation
/// as to why we would need to use a custom error category (at least on Windows).
///
/// NOTE: Currently, for OSes other than Windows, error messages are obtained via
/// `strerror()` function, which is influenced by the `LC_MESSAGES` locale category.
/// This shouldn't be a problem, though, as opposed to Windows, which suffers from the
/// aforementioned bug in MSVC STL.
/// </summary.
class GenericSystemErrorCategory : public std::error_category
{
Expand Down

0 comments on commit f520ccf

Please sign in to comment.