Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document endpoint /api/player/autocomplete (fix #847) #848

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ddugovic
Copy link

I am struggling to test this patch at the moment, however I think this should be close to correct.

@WandererXII
Copy link
Owner

/player/autocomplete is used in some places, so I think it would be better to keep that url.

@ddugovic
Copy link
Author

ddugovic commented Jul 13, 2024

OK... other lila-based sites use prefix /api for API endpoints, but Lishogi can be different for backward compatibility reasons.

@ddugovic
Copy link
Author

Sorry... actually, could I update the "ui" references to this endpoint to use /api/player/autocomplete ? Long-term it may help both future lishogi development (copying code from lila) and help client API designers to expect the same endpoint on both Lichess and Lishogi.

I can't imagine there being many other consumers of this endpoint (like mobile applications) since for Lishogi this endpoint wasn't documented/announced yet.

@WandererXII
Copy link
Owner

LGTM, thanks!

@WandererXII WandererXII merged commit 11f9451 into WandererXII:master Jul 15, 2024
3 checks passed
@ddugovic ddugovic deleted the patch-1 branch July 15, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants