Skip to content

Commit

Permalink
Change metp dependency (NOAA-EMC#1900)
Browse files Browse the repository at this point in the history
MET+ jobs rely on files already having been placed in the local
archive directory, but the job only depended on post, resulting
in the job prematurely firing. The dependency is now updated to
be on the archive job instead.

Resolves NOAA-EMC#1756
  • Loading branch information
WalterKolczynski-NOAA authored Oct 4, 2023
1 parent 836642b commit d50938b
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ def fit2obs(self):

def metp(self):
deps = []
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}post'}
dep_dict = {'type': 'task', 'name': f'{self.cdump}arch'}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep_condition='and', dep=deps)

Expand Down Expand Up @@ -917,9 +917,6 @@ def arch(self):
if self.cdump in ['gdas'] and self.app_config.do_fit2obs:
dep_dict = {'type': 'task', 'name': f'{self.cdump}fit2obs'}
deps.append(rocoto.add_dependency(dep_dict))
if self.app_config.do_metp and self.cdump in ['gfs']:
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}metp'}
deps.append(rocoto.add_dependency(dep_dict))
if self.app_config.do_wave:
dep_dict = {'type': 'task', 'name': f'{self.cdump}wavepostsbs'}
deps.append(rocoto.add_dependency(dep_dict))
Expand Down

0 comments on commit d50938b

Please sign in to comment.