Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quotas query param name #26

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: quotas query param name #26

merged 1 commit into from
May 29, 2024

Conversation

chris13524
Copy link
Member

Description

Fix failing CI in Blockchain API: https://github.com/WalletConnect/blockchain-api/actions/runs/9283394702/job/25544371126

Slack conversation

How Has This Been Tested?

Existing tests updated

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this May 29, 2024
@arein arein added the accepted The issue has been accepted into the project label May 29, 2024
@chris13524 chris13524 mentioned this pull request May 29, 2024
Merged
4 tasks
geekbrother
geekbrother approved these changes May 29, 2024
View reviewed changes
Copy link

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp 🗜️

@chris13524 chris13524 merged commit b93026b into main May 29, 2024
10 checks passed
@chris13524 chris13524 deleted the fix/quotas-query-param-name branch May 29, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

@xDarksome xDarksome Awaiting requested review from xDarksome xDarksome is a code owner

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris13524 @geekbrother @arein