fix: approve session proposal, receive session disconnect #1331
Conversation
…nV2 into fix/bunch_of_reported_issues
| @@ -358,6 +368,6 @@ internal class SignEngine( | |||
| } | |||
|
|
|||
| companion object { | |||
| private const val WATCHER_INTERVAL = 3000L | |||
| private const val WATCHER_INTERVAL = 5000L | |||
There was a problem hiding this comment.
what do you think about bumping this value to something like 10 or even 30 sec? I think to save on resources, we could check less frequently. We also have other checks to validate expiry so I think we would be ok having something longer
There was a problem hiding this comment.
Yeah I agree. I think that checking every 30s is fine
| try { | ||
| val pairingTopics = pairingRepository.getListOfPairings().filter { pairing -> pairing.isNotExpired() }.map { pairing -> pairing.topic.value } | ||
| val pairingTopics = runBlocking { pairingRepository.getListOfPairings().filter { pairing -> pairing.isNotExpired() }.map { pairing -> pairing.topic.value } } |
There was a problem hiding this comment.
why does this need to be blocking? I think we should think about going the other way and launch a coroutine in the init block and make this function a suspend function to run async. We're already launching coroutines inside of this function
There was a problem hiding this comment.
Yeah, good point. Made this function a suspend function.
It was causing session request and proposal dialogs to disappear in some corner cases |
No description provided.