Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign 2.5 #1296

Merged
merged 187 commits into from
Mar 18, 2024
Merged

Sign 2.5 #1296

merged 187 commits into from
Mar 18, 2024

Conversation

jakubuid
Copy link
Contributor

No description provided.

jakubuid added 27 commits March 11, 2024 07:51
Update sign recaps in the merged recaps
…inV2 into feat/cap_box

# Conflicts:
#	protocol/notify/src/androidTest/kotlin/com/walletconnect/notify/test/client/NotifyClientInstrumentedAndroidTest.kt
#	protocol/notify/src/androidTest/kotlin/com/walletconnect/notify/test/utils/TestClient.kt
#	protocol/notify/src/androidTest/kotlin/com/walletconnect/notify/test/utils/primary/PrimaryNotifyDelegate.kt
sign 2.5: check if session authenticate is implemented
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.3% Coverage on New Code (required ≥ 51%)
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jakubuid jakubuid merged commit c4feaa6 into develop Mar 18, 2024
8 of 9 checks passed
@jakubuid jakubuid deleted the sign_2.5 branch March 18, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants