-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 117 Merge private CollectionCost into public CollectionCost module #128
Issue 117 Merge private CollectionCost into public CollectionCost module #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parangat94, please review my questions, check the code, and check the validation data, and then send back to me for review. It doesn't look like there are any changes to the utility results so that's good but there are some enormous differences between the validation data and the model result for the DW cases.
@parangat94 Has there been any movement ahead on @eberlea comments? Once those changes are made and @eberlea approves, I will do my review. |
…py, mobilization cost for DW was being calculated on a per turbine basis rather than per project basis
@eberlea @akey7 ready for review. I've made changes per your requests and re-ran the validation. Please see results below: Important: Please note there is new expected validation data on the box. I made some minor tweaks to the expected collection cost breakdown (which were showing some minor discrepancies in expected value due to legacy bugs) |
I'm reviewing this now. I've flagged some additional comments that need to be addressed before merging. I'll let you know when I'm done reviewing and it's ready for you to make final changes before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is close. Validation passes. :-) Please address my one remaining comment below before you merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the hardcoded value of 137 to be addressed in the conversation on CollectionCost.py
@akey7 merged develop into branch PR ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation works. Looks good to me!
Ready for review.