Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when page size form is empty #398

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

sibinhho99
Copy link
Collaborator

Set default value to true and make the field compulsory

Description

Related Issue

#397

Motivation and Context

Bug fix

How Has This Been Tested?

Local testing

Screenshots (if appropriate):

Box defaults to 20 on load and if the user clears the box and click "Update", error message is raised

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Set default value to true and make the field compulsory
@sibinhho99 sibinhho99 added the bug label Dec 28, 2023
@sibinhho99 sibinhho99 self-assigned this Dec 28, 2023
@sibinhho99 sibinhho99 linked an issue Dec 28, 2023 that may be closed by this pull request
2 tasks
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 4.238%. remained the same
when pulling 81c20be on sibinhho99:fix_page_size_validation
into b4e8ad8 on WING-NUS:master.

@huyuxin0429 huyuxin0429 merged commit b30e258 into WING-NUS:master Jan 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Crash when page size form is empty
3 participants