Feature/obfuscation #304
Merged
Feature/obfuscation #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyuxin0429
added
Type: Feature
huyuxin0429
added this to the Improving plagarism detection functionality/experience milestone
|
@knmnyn Hmm I was wondering if the obfuscation functionality you request for is in masking the student names or associating the names with pseudonyms? |
huyuxin0429
requested changes
Sep 8, 2023
| // console.log("Masking student name now"); | ||
|
|
||
| // Masking inside all h4 elements to get the student pairings | ||
| let h4Elements = document.querySelectorAll('h4'); |
There was a problem hiding this comment.
hmm is it possible select by a dedicated class instead of h4
this will allow the search to be more targeted
There was a problem hiding this comment.
likewise for other query selector functions
Comment on lines
47
to
49
| // console.log("Report Fn Hit") | ||
| // console.log(window.shouldNotObfuscate) | ||
| // console.log("Local Storage", shouldNotObfuscate) |
There was a problem hiding this comment.
Try to remove unused logs if possible!
huyuxin0429
force-pushed
the
feature/obfuscation
branch
from
2ecd553 to
d041556
Compare
huyuxin0429
requested changes
Sep 27, 2023
| let h4Elements = document.querySelectorAll('h4'); | ||
| h4Elements.forEach(h4Element => { | ||
|
|
||
| // Masking inside all h4 elements with id "submission_similarities_for_students" to get the student pairings |
There was a problem hiding this comment.
Hmm is "submission_similarities_for_students" id or class?
| return; | ||
| } | ||
|
|
||
| // console.log("Masking student name now"); |
There was a problem hiding this comment.
Removed unused logging statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #281
By default, obfuscation is added, and if the checkbox is ticked, student names would be revealed
video1927682058.mp4