Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite into ESM #281

Merged
merged 9 commits into from
Feb 2, 2024
Merged

feat: rewrite into ESM #281

merged 9 commits into from
Feb 2, 2024

Conversation

TobiTenno
Copy link
Member

Summary

  • drop node 12, node 14 support
  • add node 20 support, add node 18 support
  • BREAKING CHANGE: prefer .make static functions to constructors

Resolves issue
closes #165


Screenshots/examples

drop node 12, node 14 support

add node 20 support, add node 18 support

BREAKING CHANGE: prefer .make static functions to constructors
@TobiTenno TobiTenno requested a review from a team as a code owner January 28, 2024 01:19
@TobiTenno TobiTenno enabled auto-merge (squash) January 28, 2024 01:20
codeclimate[bot]

This comment was marked as outdated.

codeclimate[bot]

This comment was marked as resolved.

codeclimate[bot]

This comment was marked as resolved.

codeclimate[bot]

This comment was marked as resolved.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10772 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jan 28, 2024

Code Climate has analyzed commit 16ec2d6 and detected 0 issues on this pull request.

View more on Code Climate.

@TobiTenno TobiTenno requested a review from AyAyEm January 28, 2024 02:18
Copy link
Member

@AyAyEm AyAyEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much change 😵‍💫
Please make a separate PR next time

@TobiTenno TobiTenno merged commit cd70cec into master Feb 2, 2024
9 checks passed
@TobiTenno TobiTenno deleted the ESM-rewrite branch February 2, 2024 01:28
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert worldstate-emitter to ES
3 participants