Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new explore page #414

Merged
merged 17 commits into from
Mar 30, 2024
Merged

feat: new explore page #414

merged 17 commits into from
Mar 30, 2024

Conversation

SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented Mar 16, 2024

Description

Create a new explore page with information on fish and to reintroduce maps eventually. This will also move the codex page over to the new explore page and make room for a personal inventory page #94

  • move codex
  • add fish information page

Will update comment with previews as I go

Codex:
https://github.com/WFCD/navis/assets/6075693/13c44b25-83bc-4e9a-9254-2c96c8d1cf0a

Fishing data:
https://github.com/WFCD/navis/assets/6075693/f3d9dc73-a23a-4701-9a08-2f3c54ddc35c

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the feature, but the border radius on the selection items for the codex are so close that they just make some dots on the sides

@SlayerOrnstein
Copy link
Member Author

I like the feature, but the border radius on the selection items for the codex are so close that they just make some dots on the sides

Screenshot_20240317-121504.png

You mean this?

@TobiTenno
Copy link
Member

@SlayerOrnstein from your video:

image

@TobiTenno
Copy link
Member

feel free to merge when it works for you 🖖

@SlayerOrnstein
Copy link
Member Author

Maps are being annoying and it's gonna take me a fair bit to figure it out so I'm gonna push that part to a different PR, good news is I have a better idea of what I can do, bad news is that plotting coordinates is still bleh

@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) March 30, 2024 02:57
@SlayerOrnstein SlayerOrnstein merged commit 1f37a18 into master Mar 30, 2024
3 checks passed
@SlayerOrnstein SlayerOrnstein deleted the next branch March 30, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants