Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add logging to AbstractMethod.execute #559

Merged
merged 8 commits into from
Jan 9, 2025
Merged

fix: Add logging to AbstractMethod.execute #559

merged 8 commits into from
Jan 9, 2025

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Jan 8, 2025

This PR removes declarations of Apache Commons loggers and adds log statements for requests and responses made using the SDK, using java.util.logging with INFO level. This is all centralised in AbstractMethod#execute(T) for simplicity.

EDIT: Also added non-static logging to DynamicEndpoint so each individual endpoint implementation can have its own logging of raw request and responses prior to (de-)serialisation.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 85.24590% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (fe06b81) to head (ab7f3a8).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/com/vonage/client/DynamicEndpoint.java 72.22% 5 Missing ⚠️
...in/java/com/vonage/client/auth/RequestSigning.java 70.00% 3 Missing ⚠️
...rc/main/java/com/vonage/client/AbstractMethod.java 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #559      +/-   ##
============================================
+ Coverage     95.60%   95.96%   +0.36%     
- Complexity     3427     3770     +343     
============================================
  Files           513      564      +51     
  Lines          8141     8747     +606     
  Branches        451      506      +55     
============================================
+ Hits           7783     8394     +611     
+ Misses          198      179      -19     
- Partials        160      174      +14     
Files with missing lines Coverage Δ
...rc/main/java/com/vonage/client/AbstractMethod.java 98.07% <96.96%> (+20.29%) ⬆️
...in/java/com/vonage/client/auth/RequestSigning.java 73.11% <70.00%> (-10.40%) ⬇️
...c/main/java/com/vonage/client/DynamicEndpoint.java 83.01% <72.22%> (+6.25%) ⬆️

... and 116 files with indirect coverage changes

@SMadani SMadani merged commit cd8527d into main Jan 9, 2025
17 checks passed
@SMadani SMadani deleted the logging branch January 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants