Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern matching instanceof not being detected inside loops #450

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix pattern matching instanceof not being detected inside loops #450

merged 1 commit into from
Jan 9, 2025
+63 −2

Conversation

coehlrich
Copy link
Contributor

Fixes pattern matching instanceof not always being detected inside loops due to the predecessors check ending up inside the statement

jaskarth
jaskarth approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@jaskarth jaskarth added Subsystem: Statement Structure Anything concerning how statements are structured in a method Priority: Low Low priority Subsystem: Variables Anything concerning variables, types, assignments, and casting bugfix Fixes a bug labels Jan 9, 2025
@jaskarth jaskarth merged commit 5de1cc3 into Vineflower:develop/1.11.0 Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees
No one assigned
Labels
bugfix Fixes a bug Priority: Low Low priority Subsystem: Statement Structure Anything concerning how statements are structured in a method Subsystem: Variables Anything concerning variables, types, assignments, and casting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coehlrich @jaskarth